[#49][REFACTOR] Added status filter and added tests

core/tests/test_vacancies.py

@@ -205,6 +205,17 @@ class CompanyListsTests(APITestCase):
         response = self.client.get(url, format='json')
         self.assertEqual(response.status_code, status.HTTP_200_OK)
 
+    def test_company_application_list_with_status(self):
+        new_user = User.objects.create_user('dummy.company4', 'dummy.company4@company.com', 'lalala123')
+        new_company = Company.objects.create(user=new_user, description="lalala", status=Company.VERIFIED, logo=None,
+                                             address=None)
+
+        self.client.force_authenticate(new_user)
+
+        url = '/api/companies/' + str(new_company.pk) + '/applications/?status=0'
+        response = self.client.get(url, format='json')
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+
     def test_company_application_list_unauthorized(self):
         new_user = User.objects.create_user('dummy.company3', 'dummy.company3@company.com', 'lalala123')
         new_company = Company.objects.create(user=new_user, description="lalala", status=Company.VERIFIED, logo=None,
@@ -282,3 +293,75 @@ class CompanyListsTests(APITestCase):
         url = '/api/companies/' + str(new_company3.pk) + '/applications/' + str(new_vacancy.pk) + '/by_vacancy/'
         response = self.client.get(url, format='json')
         self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)
+
+    def test_company_application_list_by_vacancy_with_status(self):
+        new_user = User.objects.create_user('dummy.company3', 'dummy.company3@company.com', 'lalala123')
+        new_company = Company.objects.create(user=new_user, description="lalala", status=Company.VERIFIED, logo=None,
+                                             address=None)
+
+        new_user2 = User.objects.create_user('dummy.company4', 'dummy.company4@company.com', 'lalala123')
+        new_student = Student.objects.create(user=new_user2, npm=1234123412)
+
+        new_vacancy = Vacancy.objects.create(company=new_company, verified=True, open_time=datetime.fromtimestamp(0),
+                                             description="lalala", close_time=datetime.today())
+        new_app = Application.objects.create(student=new_student, vacancy=new_vacancy, cover_letter="asdasdasd")
+
+        self.client.force_authenticate(new_user)
+
+        url = '/api/companies/' + str(new_company.pk) + '/applications/' + str(new_vacancy.pk) + '/by_vacancy/?status=2'
+        response = self.client.get(url, format='json')
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+
+    def test_company_application_list_by_vacancy_with_bad_status_string(self):
+        new_user = User.objects.create_user('dummy.company3', 'dummy.company3@company.com', 'lalala123')
+        new_company = Company.objects.create(user=new_user, description="lalala", status=Company.VERIFIED, logo=None,
+                                             address=None)
+
+        new_user2 = User.objects.create_user('dummy.company4', 'dummy.company4@company.com', 'lalala123')
+        new_student = Student.objects.create(user=new_user2, npm=1234123412)
+
+        new_vacancy = Vacancy.objects.create(company=new_company, verified=True, open_time=datetime.fromtimestamp(0),
+                                             description="lalala", close_time=datetime.today())
+        new_app = Application.objects.create(student=new_student, vacancy=new_vacancy, cover_letter="asdasdasd")
+
+        self.client.force_authenticate(new_user)
+
+        url = '/api/companies/' + str(new_company.pk) + '/applications/' + str(new_vacancy.pk) + '/by_vacancy/?status=lalala'
+        response = self.client.get(url, format='json')
+        self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
+
+    def test_company_application_list_by_vacancy_with_bad_status_negative(self):
+        new_user = User.objects.create_user('dummy.company3', 'dummy.company3@company.com', 'lalala123')
+        new_company = Company.objects.create(user=new_user, description="lalala", status=Company.VERIFIED, logo=None,
+                                             address=None)
+
+        new_user2 = User.objects.create_user('dummy.company4', 'dummy.company4@company.com', 'lalala123')
+        new_student = Student.objects.create(user=new_user2, npm=1234123412)
+
+        new_vacancy = Vacancy.objects.create(company=new_company, verified=True, open_time=datetime.fromtimestamp(0),
+                                             description="lalala", close_time=datetime.today())
+        new_app = Application.objects.create(student=new_student, vacancy=new_vacancy, cover_letter="asdasdasd")
+
+        self.client.force_authenticate(new_user)
+
+        url = '/api/companies/' + str(new_company.pk) + '/applications/' + str(new_vacancy.pk) + '/by_vacancy/?status=-1'
+        response = self.client.get(url, format='json')
+        self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
+
+    def test_company_application_list_by_vacancy_with_bad_status_large(self):
+        new_user = User.objects.create_user('dummy.company3', 'dummy.company3@company.com', 'lalala123')
+        new_company = Company.objects.create(user=new_user, description="lalala", status=Company.VERIFIED, logo=None,
+                                             address=None)
+
+        new_user2 = User.objects.create_user('dummy.company4', 'dummy.company4@company.com', 'lalala123')
+        new_student = Student.objects.create(user=new_user2, npm=1234123412)
+
+        new_vacancy = Vacancy.objects.create(company=new_company, verified=True, open_time=datetime.fromtimestamp(0),
+                                             description="lalala", close_time=datetime.today())
+        new_app = Application.objects.create(student=new_student, vacancy=new_vacancy, cover_letter="asdasdasd")
+
+        self.client.force_authenticate(new_user)
+
+        url = '/api/companies/' + str(new_company.pk) + '/applications/' + str(new_vacancy.pk) + '/by_vacancy/?status=5'
+        response = self.client.get(url, format='json')
+        self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)

core/views/vacancies.py

@@ -130,6 +130,17 @@ class CompanyApplicationViewSet(viewsets.GenericViewSet):
         if vacancy.company != company:
             return Response({"error": "forbidden"}, status=status.HTTP_403_FORBIDDEN)
         applications = Application.objects.filter(vacancy=vacancy)
+        st = request.query_params.get('status', None)
+        if st is not None:
+            try:
+                st = int(st)
+                if st < 0 or st > 4:
+                    return Response({"error": "status must be an integer between 0 and 4"},
+                                    status=status.HTTP_400_BAD_REQUEST)
+                applications = applications.filter(status=st)
+            except:
+                return Response({"error": "status must be an integer between 0 and 4"}, \
+                                status=status.HTTP_400_BAD_REQUEST)
         page = self.paginate_queryset(applications)
         if page is not None:
             return self.get_paginated_response(