Kape merge requestshttps://gitlab.cs.ui.ac.id/foss/kape/-/merge_requests2019-10-05T21:10:12+07:00https://gitlab.cs.ui.ac.id/foss/kape/-/merge_requests/171606823475-342019-10-05T21:10:12+07:00Muhammad Ilham Peruzzi1606823475-34- Melakukan extract method pada class CompanyApplicationViewSet
- Mengubah date_start pada pembuatan object Vacancy di test_vacancies.py menjadi angka bukan nol dikarenakan terdapat bug pada pyton 3 keatas yang menyebabkan OSError
- Meng...- Melakukan extract method pada class CompanyApplicationViewSet
- Mengubah date_start pada pembuatan object Vacancy di test_vacancies.py menjadi angka bukan nol dikarenakan terdapat bug pada pyton 3 keatas yang menyebabkan OSError
- Mengubah date_end pada pembuatan object Vacancy di test_vacancies.py menjadi menggunakan module timezone untuk mengurangi timezone warninghttps://gitlab.cs.ui.ac.id/foss/kape/-/merge_requests/161606833463 31 (Menambah Atribut alamat LinkedIn pada profile mahasiswa)2019-10-05T17:43:00+07:00Aldo Bima Syahputra1606833463 31 (Menambah Atribut alamat LinkedIn pada profile mahasiswa)Mengerjakan issue no #31
Perubahan pada MR ini :
1) membuat test apabila request update profile dengan data linked in url yang valid, maka akan mengembalikan status 200 dan model terupdate dengan data baru
2) membuat test apabila reques...Mengerjakan issue no #31
Perubahan pada MR ini :
1) membuat test apabila request update profile dengan data linked in url yang valid, maka akan mengembalikan status 200 dan model terupdate dengan data baru
2) membuat test apabila request update profile dengan data linked in url yang 1valid, maka akan mengembalikan status 400 bad request
3) menambah field linkedin_url pada model dan implementasi update profile dengan data linked in pada backend
4) membuat field form linkedin url dan menampilkan data linked in tiap user pada frontendhttps://gitlab.cs.ui.ac.id/foss/kape/-/merge_requests/131606821601 01 - Implementasi backend (create, read, dan delete) Fitur Evaluas...2019-10-08T19:15:20+07:00Arga Ghulam Ahmad1606821601 01 - Implementasi backend (create, read, dan delete) Fitur Evaluasi Sistem Kape oleh Mahasiswahttps://gitlab.cs.ui.ac.id/foss/kape/-/merge_requests/121606918484 03 API for accepting only one application and abort the rest2019-10-05T14:02:08+07:00Muhammad At Thoriq1606918484 03 API for accepting only one application and abort the restPrevious feature: Student can be accepted by many companies on many vacancies.
Proposed feature: Student be able to accept only one vacancy and abort the rest applications by changing the application status. So now, application status is...Previous feature: Student can be accepted by many companies on many vacancies.
Proposed feature: Student be able to accept only one vacancy and abort the rest applications by changing the application status. So now, application status is not only be changed by company, it also could be changed by student through aborting applications feature.https://gitlab.cs.ui.ac.id/foss/kape/-/merge_requests/101606918484 03 API for accepting only one application and abort the rest2019-10-05T14:00:37+07:00Muhammad At Thoriq1606918484 03 API for accepting only one application and abort the resthttps://gitlab.cs.ui.ac.id/foss/kape/-/merge_requests/9Sebagai perusahaan, saya ingin menyimpan kategori perusahaan #102019-10-05T12:50:48+07:00Fajrin KingwijatiSebagai perusahaan, saya ingin menyimpan kategori perusahaan #10https://gitlab.cs.ui.ac.id/foss/kape/-/merge_requests/8Fitur validasi waktu membuka atau update lowongan agar close_time selalu lebi...2019-10-05T19:09:33+07:00Kemas Khaidar Ali IndrakusumaFitur validasi waktu membuka atau update lowongan agar close_time selalu lebih dari open_timehttps://gitlab.cs.ui.ac.id/foss/kape/-/merge_requests/7WIP: 160682160- 01 (Fitur Evaluasi Sistem KaPe oleh Mahasiswa dan Perusahaan ...2019-10-03T19:50:58+07:00Arga Ghulam AhmadWIP: 160682160- 01 (Fitur Evaluasi Sistem KaPe oleh Mahasiswa dan Perusahaan #1 - backend) - Submission1https://gitlab.cs.ui.ac.id/foss/kape/-/merge_requests/6WIP: 1606821601/submission12019-10-03T19:36:57+07:00Arga Ghulam AhmadWIP: 1606821601/submission1https://gitlab.cs.ui.ac.id/foss/kape/-/merge_requests/51806280520-08 : Extract Long Method on create method2019-10-03T19:51:09+07:00Muh Riansyah Tohamba1806280520-08 : Extract Long Method on create methodsaya melakukan extract method refactoring pada method create di class LoginViewSet. Beberapa method kecil yanng dihasilkan setelah ekstraksi diantaranya
1. create_user
2. company_login
3. sso_ui_loginsaya melakukan extract method refactoring pada method create di class LoginViewSet. Beberapa method kecil yanng dihasilkan setelah ekstraksi diantaranya
1. create_user
2. company_login
3. sso_ui_loginhttps://gitlab.cs.ui.ac.id/foss/kape/-/merge_requests/406-1606887352 (Fix broken signup/login for students)2019-10-02T10:37:14+07:00IVANA IRENE THOMAS06-1606887352 (Fix broken signup/login for students)Issue - https://gitlab.cs.ui.ac.id/pmpl/class-project/kape/issues/6
The current backend process of login for student is:
* Create user
* If role == 'mahasiswa', fetch student detail and create Student object
This process is bro...Issue - https://gitlab.cs.ui.ac.id/pmpl/class-project/kape/issues/6
The current backend process of login for student is:
* Create user
* If role == 'mahasiswa', fetch student detail and create Student object
This process is broken because fetching student's detail from https://api.cs.ui.ac.id/siakngcs/mahasiswa/{npm}/(https://api.cs.ui.ac.id/siakngcs/mahasiswa/%7Bnpm%7D/) requires authentication which is not currently provided, the front end will always show that username/password is wrong even though it is correct because of the 403 error.
This fix will instead create student's object based on simple information from https://api.cs.ui.ac.id/authentication/ldap/v2/ response and let student's edit information such as birth place, birth date, major, and batch after they are successfully logged in.
What's done in MR:
- Create test to test whether student object is created (without mocking succesful response to [https://api.cs.ui.ac.id/siakngcs/mahasiswa/{npm}/]
- Create student object without student detail information
- Modify student serializers and update method to add additional fields
- Add additional fields in edit profile to accommodate reduced information from signup
(Added fields on edit profile page)
![image](/uploads/1e3ef7e31f35eb1f5c4eaecf4758bd11/image.png)https://gitlab.cs.ui.ac.id/foss/kape/-/merge_requests/2Add API CS Implementation SSO Related Data2019-09-30T13:50:43+07:00HafiyyanAdd API CS Implementation SSO Related Data