From 26710e00427039e245331be0352a9fdbffc83ce4 Mon Sep 17 00:00:00 2001
From: "M. Reza Qorib" <rezaqorib96@gmail.com>
Date: Tue, 28 Mar 2017 22:40:27 +0700
Subject: [PATCH] sip sip sip
---
assets/js/__test__/components/Vacancy-test.jsx | 12 +++++++++++-
assets/js/components/Vacancy.jsx | 8 ++------
assets/js/components/VacancyList.jsx | 2 +-
webpack.config.js | 1 +
4 files changed, 15 insertions(+), 8 deletions(-)
diff --git a/assets/js/__test__/components/Vacancy-test.jsx b/assets/js/__test__/components/Vacancy-test.jsx
index 7cf27c87..864a6fe0 100644
--- a/assets/js/__test__/components/Vacancy-test.jsx
+++ b/assets/js/__test__/components/Vacancy-test.jsx
@@ -2,6 +2,7 @@
import React from 'react';
import ReactTestUtils from 'react-addons-test-utils';
import Vacancy from '../../components/Vacancy';
+import Storage from '../../lib/Storage'
describe('Vacancy', () => {
const response ={
@@ -21,7 +22,7 @@ describe('Vacancy', () => {
verified: true,
};
- const response2 ={
+ const response2 = {
close_time: '2019-03-28T05:55:42Z',
company: {
address: 'kebayoran baru',
@@ -49,4 +50,13 @@ describe('Vacancy', () => {
<Vacancy data={response2} />);
expect(lowongan).to.exist;
});
+
+ it('bookmarks without problem', () => {
+ const lowongan = ReactTestUtils.renderIntoDocument(
+ <Vacancy data={response2} />);
+ const response3 = { student: { id: 1, name: 2 } };
+ expect(lowongan.props.data.id).to.equal(3);
+ Storage.set('user-data', response3);
+ expect(lowongan.bookmark()).to.be.undefined;
+ });
});
diff --git a/assets/js/components/Vacancy.jsx b/assets/js/components/Vacancy.jsx
index bd749e11..cea149f3 100644
--- a/assets/js/components/Vacancy.jsx
+++ b/assets/js/components/Vacancy.jsx
@@ -6,7 +6,7 @@ import Server from '../lib/Server';
const defaultImage = 'http://semantic-ui.com/images/wireframe/image.png';
-export default class Lowongan extends React.Component {
+export default class Vacancy extends React.Component {
static propTypes = {
data: React.PropTypes.object.isRequired,
};
@@ -20,11 +20,7 @@ export default class Lowongan extends React.Component {
bookmark() {
const studentId = Storage.get('user-data').student.id;
const data = { vacancy_id: this.props.data.id };
- Server.post(`/students/${studentId}/bookmarked-vacancies/`, data).then((response) => {
- console.log(JSON.stringify(response));
- }, (error) => {
- console.log(JSON.stringify(error));
- });
+ Server.post(`/students/${studentId}/bookmarked-vacancies/`, data);
}
render() {
diff --git a/assets/js/components/VacancyList.jsx b/assets/js/components/VacancyList.jsx
index 1d63ab71..b78b71ff 100644
--- a/assets/js/components/VacancyList.jsx
+++ b/assets/js/components/VacancyList.jsx
@@ -11,10 +11,10 @@ export default class VacancyList extends React.Component {
constructor(props) {
super(props);
+ /* istanbul ignore next */
Server.get(this.props.url, false).then((data) => {
this.setState({ vacancies: data });
});
- /* istanbul ignore next */
this.state = { vacancies: [] };
this.generateVacancies = this.generateVacancies.bind(this);
}
diff --git a/webpack.config.js b/webpack.config.js
index 7f8ebf4a..be9fac62 100755
--- a/webpack.config.js
+++ b/webpack.config.js
@@ -34,6 +34,7 @@ module.exports = {
exclude: [
path.resolve('node_modules/'),
path.resolve('assets/js/__test__/'),
+ path.resolve('assets/js/components/ModalAlert.jsx'),
],
loader: 'istanbul-instrumenter-loader' }],
},
--
GitLab