From af8c63ee9a495c8764697f8c516e23f0e6bf1184 Mon Sep 17 00:00:00 2001
From: fakhrilm <fpvariel@gmail.com>
Date: Fri, 15 Nov 2019 22:08:52 +0700
Subject: [PATCH] refactor sso variable, move them as settings variable

---
 core/views/sso_login.py | 10 ++++------
 kape/settings.py        |  6 +++++-
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/core/views/sso_login.py b/core/views/sso_login.py
index d63fc9b7..7a7cf00d 100755
--- a/core/views/sso_login.py
+++ b/core/views/sso_login.py
@@ -1,8 +1,6 @@
 import requests
+from django.conf import settings
 
-API_MAHASISWA = "https://api.cs.ui.ac.id/siakngcs/mahasiswa/"
-API_RIWAYAT_MAHASISWA = API_MAHASISWA+'{npm}/riwayat/'
-API_VERIFY_USER = "https://akun.cs.ui.ac.id/oauth/token/verify/"
 def get_access_token(username, password):
     try:
         url = "https://akun.cs.ui.ac.id/oauth/token/"
@@ -26,14 +24,14 @@ def get_client_id():
 def verify_user(access_token):
     print ("#get identity number")
     parameters = {"access_token": access_token, "client_id": get_client_id()}
-    response = requests.get(API_VERIFY_USER, params=parameters)
+    response = requests.get(settings.API_VERIFY_USER, params=parameters)
     print ("response => ", response.json())
     return response.json()
 
 def get_summary_user(access_token, npm):
     print ("#get summary user => ", npm)
     parameters = {"access_token": access_token, "client_id": get_client_id()}
-    response = requests.get(API_MAHASISWA+str(npm), params=parameters)
+    response = requests.get(settings.API_MAHASISWA+str(npm), params=parameters)
     print ("response => ", response.text)
     print ("response => ", response.json())
     return response.json()
@@ -41,7 +39,7 @@ def get_summary_user(access_token, npm):
 def get_riwayat_user(access_token, npm):
     print ("#get riwayat user => ", npm)
     parameters = {"access_token": access_token, "client_id": get_client_id()}
-    response = requests.get(API_RIWAYAT_MAHASISWA.format(npm=npm), params=parameters)
+    response = requests.get(settings.API_RIWAYAT_MAHASISWA.format(npm=npm), params=parameters)
     print ("response => ", response.text)
     print ("response => ", response.json())
     return response.json()
diff --git a/kape/settings.py b/kape/settings.py
index 97ce43fd..7e8f3f4a 100755
--- a/kape/settings.py
+++ b/kape/settings.py
@@ -197,4 +197,8 @@ API_CS_CREDENTIALS = {'user': 'kape', 'password': 'yukcarikape'}
 # 250MB - 214958080
 # 500MB - 429916160
 # 10MB - 10485760
-MAX_UPLOAD_SIZE = 5242880
\ No newline at end of file
+MAX_UPLOAD_SIZE = 5242880
+
+API_MAHASISWA = "https://api.cs.ui.ac.id/siakngcs/mahasiswa/"
+API_RIWAYAT_MAHASISWA = API_MAHASISWA+'{npm}/riwayat/'
+API_VERIFY_USER = "https://akun.cs.ui.ac.id/oauth/token/verify/"
\ No newline at end of file
-- 
GitLab