Fakultas Ilmu Komputer UI
Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
PMPL
Class Project
DIGIPUS
Commits
1ad44617
Commit
1ad44617
authored
Oct 29, 2020
by
arif teguh wangi
Browse files
[
#48
] Material: User Review (Create)( fix code smell)
parent
93893654
Changes
2
Hide whitespace changes
Inline
Side-by-side
app/tests.py
View file @
1ad44617
...
...
@@ -334,18 +334,18 @@ class DetailMateriTest(TestCase):
def
test_category_models_can_create_new_object
(
self
):
test
=
Category
.
objects
.
create
(
id
=
"1"
,
name
=
"medis"
,
description
=
"kategori medis"
)
count
Data
=
Category
.
objects
.
all
().
count
()
self
.
assertEqual
(
1
,
count
Data
)
self
.
assertNotEqual
(
0
,
count
Data
)
count
=
Category
.
objects
.
all
().
count
()
self
.
assertEqual
(
1
,
count
)
self
.
assertNotEqual
(
0
,
count
)
self
.
assertEqual
(
test
.
__str__
(),
"medis"
)
self
.
assertNotEqual
(
test
.
__str__
(),
"saul"
)
def
test_comment_models_can_create_new_object
(
self
):
test
=
Comment
.
objects
.
create
(
username
=
"saul"
,
profile
=
"121212"
,
comment
=
"232323"
)
count
Data
=
Comment
.
objects
.
all
().
count
()
self
.
assertEqual
(
1
,
count
Data
)
self
.
assertNotEqual
(
0
,
count
Data
)
count
=
Comment
.
objects
.
all
().
count
()
self
.
assertEqual
(
1
,
count
)
self
.
assertNotEqual
(
0
,
count
)
self
.
assertEqual
(
test
.
__str__
(),
"saul"
)
self
.
assertNotEqual
(
test
.
__str__
(),
"userlain"
)
...
...
@@ -543,9 +543,9 @@ class DetailMateriTest(TestCase):
def
test_review_models_can_create_new_object
(
self
):
test
=
Review
.
objects
.
create
(
username
=
"saul"
,
profile
=
"121212"
,
review
=
"232323"
)
count
Data
=
Review
.
objects
.
all
().
count
()
self
.
assertEqual
(
1
,
count
Data
)
self
.
assertNotEqual
(
0
,
count
Data
)
count
=
Review
.
objects
.
all
().
count
()
self
.
assertEqual
(
1
,
count
)
self
.
assertNotEqual
(
0
,
count
)
self
.
assertEqual
(
test
.
__str__
(),
"saul"
)
self
.
assertNotEqual
(
test
.
__str__
(),
"userlain"
)
...
...
@@ -590,14 +590,14 @@ class DetailMateriTest(TestCase):
def
test_detail_materi_contains_review_count
(
self
):
url
=
self
.
url
self
.
client
.
login
(
**
self
.
contributor_credential
)
review
=
"This is new review by Contributor"
response
=
self
.
client
.
get
(
url
)
self
.
assertContains
(
response
,
"Review (0)"
)
self
.
client
.
post
(
url
,
{
"review"
:
"This is new review by Contributor"
})
url
,
{
"review"
:
review
})
self
.
client
.
post
(
url
,
{
"review"
:
"This is new review by Contributor"
})
url
,
{
"review"
:
review
})
response
=
self
.
client
.
get
(
url
)
self
.
assertContains
(
response
,
"Review (2)"
)
...
...
app/views.py
View file @
1ad44617
...
...
@@ -137,9 +137,9 @@ class DetailMateri(TemplateView):
def
post
(
self
,
request
,
*
args
,
**
kwargs
):
comment
T
ext
=
request
.
POST
.
get
(
"comment"
,
None
)
review
T
ext
=
request
.
POST
.
get
(
"review"
,
None
)
if
((
comment
T
ext
==
None
or
comment
T
ext
==
""
)
and
(
review
T
ext
==
None
or
review
T
ext
==
""
)):
comment
_t
ext
=
request
.
POST
.
get
(
"comment"
,
None
)
review
_t
ext
=
request
.
POST
.
get
(
"review"
,
None
)
if
((
comment
_t
ext
==
None
or
comment
_t
ext
==
""
)
and
(
review
_t
ext
==
None
or
review
_t
ext
==
""
)):
context
=
self
.
get_context_data
(
*
args
,
**
kwargs
)
context
[
"error_message"
]
=
"Anda belum menuliskan komentar"
context
[
"materi_data"
]
=
get_object_or_404
(
Materi
,
pk
=
kwargs
[
"pk"
])
...
...
@@ -152,14 +152,14 @@ class DetailMateri(TemplateView):
materi
=
get_object_or_404
(
Materi
,
pk
=
kwargs
[
"pk"
])
user_obj
=
request
.
user
if
request
.
user
.
is_authenticated
else
None
if
user_obj
:
if
(
comment
T
ext
!=
None
):
if
(
comment
_t
ext
!=
None
):
comment
=
Comment
.
objects
.
create
(
comment
=
comment
T
ext
,
username
=
DetailMateriService
.
get_user_name
(
request
),
materi
=
materi
,
user
=
user_obj
comment
=
comment
_t
ext
,
username
=
DetailMateriService
.
get_user_name
(
request
),
materi
=
materi
,
user
=
user_obj
)
comment
.
save
()
elif
(
review
T
ext
!=
None
):
elif
(
review
_t
ext
!=
None
):
review
=
Review
.
objects
.
create
(
review
=
review
T
ext
,
username
=
DetailMateriService
.
get_user_name
(
request
),
materi
=
materi
,
user
=
user_obj
review
=
review
_t
ext
,
username
=
DetailMateriService
.
get_user_name
(
request
),
materi
=
materi
,
user
=
user_obj
)
review
.
save
()
return
HttpResponseRedirect
(
request
.
path
)
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment