From 355c8d09912600b22107e7a232995f4767f452ad Mon Sep 17 00:00:00 2001
From: Bunga Amalia Kurniawati <bunga.amalia@ui.ac.id>
Date: Sat, 31 Oct 2020 20:41:55 +0700
Subject: [PATCH] [#133] QA: Fix Bugs Detected By Sonarqube (Part 2)
---
administration/templates/detail_verif.html | 24 ++++++++++++--------
administration/templates/laporan_materi.html | 1 +
app/templates/app/detail_materi.html | 4 ++--
app/templates/statistik.html | 5 ++--
4 files changed, 21 insertions(+), 13 deletions(-)
diff --git a/administration/templates/detail_verif.html b/administration/templates/detail_verif.html
index a5755d3..e516120 100644
--- a/administration/templates/detail_verif.html
+++ b/administration/templates/detail_verif.html
@@ -52,25 +52,31 @@ Pratinjau Materi
{% if riwayat %}
<div class="info-wrapper">
<div class="info" id="1">
- <dt class="col col-4">
- <p class="info-name"><strong>Verifikatur</strong></p>
- </dt>
+ <dl>
+ <dt class="col col-4">
+ <p class="info-name"><strong>Verifikatur</strong></p>
+ </dt>
+ </dl>
<dd>
<p class="info-content">{{verification_report.user.name}}</p>
</dd>
</div>
<div class="info" id="1">
- <dt class="col col-4">
- <p class="info-name"><strong>Waktu Verifikasi</strong></p>
- </dt>
+ <dl>
+ <dt class="col col-4">
+ <p class="info-name"><strong>Waktu Verifikasi</strong></p>
+ </dt>
+ </dl>
<dd>
<p class="info-content">{{verification_report.timestamp}}</p>
</dd>
</div>
<div class="info" id="1">
- <dt class="col col-4">
- <p class="info-name"><strong>Status Materi</strong></p>
- </dt>
+ <dl>
+ <dt class="col col-4">
+ <p class="info-name"><strong>Status Materi</strong></p>
+ </dt>
+ </dl>
<dd>
<p class="info-content">{{verification_report.status}}</p>
</dd>
diff --git a/administration/templates/laporan_materi.html b/administration/templates/laporan_materi.html
index 25849b3..023241d 100644
--- a/administration/templates/laporan_materi.html
+++ b/administration/templates/laporan_materi.html
@@ -22,6 +22,7 @@
<div class="card-body">
<div class="table-responsive">
<table class="table table-bordered" id="dataTable">
+ <caption>Materi yang Dilaporkan</caption>
<thead>
<tr>
<th scope="col">Judul</th>
diff --git a/app/templates/app/detail_materi.html b/app/templates/app/detail_materi.html
index c083179..c489843 100644
--- a/app/templates/app/detail_materi.html
+++ b/app/templates/app/detail_materi.html
@@ -312,7 +312,7 @@ div.review {
<div style="border-top:1px solid #d4d4d4;text-align:center">
<h3>Video</h3>
<iframe src="https://www.youtube.com/embed/{{ materi_data.yt_video_id }}"
- allowfullscreen="allowfullscreen"
+ title="Video materi" allowfullscreen="allowfullscreen"
width="564" height="300">
invalid video url
</iframe>
@@ -472,7 +472,7 @@ div.review {
{% endblock content %}
{% block extra_scripts %}
<script src="https://kit.fontawesome.com/bc2cedd6b2.js" crossorigin="anonymous"></script>
-<script type="text/javascript">
+<script>
// using jQuery
var csrftoken = jQuery("[name=csrfmiddlewaretoken]").val();
diff --git a/app/templates/statistik.html b/app/templates/statistik.html
index 839895c..0f2bc4e 100644
--- a/app/templates/statistik.html
+++ b/app/templates/statistik.html
@@ -24,9 +24,10 @@
<div class="card-body">
<div class="table-responsive">
<table class="table table-bordered">
+ <caption>Summary Materi per Kategori</caption>
<thead>
- <th>Kategori</th>
- <th>Jumlah Materi</th>
+ <th scope="col">Kategori</th>
+ <th scope="col">Jumlah Materi</th>
</thead>
<tbody>
{% for s in stats %}
--
GitLab