From 764cc1c58450e0af84aae547d52d3227af22d771 Mon Sep 17 00:00:00 2001 From: Ahmad Fauzan Amirul Isnain Date: Sat, 31 Oct 2020 12:10:38 +0700 Subject: [PATCH 1/4] [RED] Create tests for PeriodForm validation start date is none --- administration/tests.py | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/administration/tests.py b/administration/tests.py index 6ba9e50..641e503 100644 --- a/administration/tests.py +++ b/administration/tests.py @@ -10,7 +10,9 @@ from app.models import Category, Materi, LaporanMateri from authentication.models import User from bs4 import BeautifulSoup -from datetime import datetime +from datetime import datetime, timedelta + +from .forms import PeriodForm EDIT_ENDPOINT = "/edit" ERROR_403_MESSAGE = 'Kamu harus login untuk mengakses halaman ini' @@ -1659,3 +1661,16 @@ class EditKontributorStatusTests(TestCase): self.assertEqual(response.status_code, 403) +class PeriodFormTests(TestCase): + + def test_validation_error_when_start_date_is_none(self): + data = { + 'start_date': None, + 'end_date': datetime.now(), + } + form = PeriodForm(data) + self.assertFalse(form.is_valid()) + self.assertEqual( + form["start_date"].errors, + ['masukan waktu mulai'] + ) -- GitLab From 24d1e4181e7c510cb0ce4ce440a2d755d892aa38 Mon Sep 17 00:00:00 2001 From: Ahmad Fauzan Amirul Isnain Date: Sat, 31 Oct 2020 12:10:54 +0700 Subject: [PATCH 2/4] [RED] Create tests for PeriodForm validation end date is none --- administration/tests.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/administration/tests.py b/administration/tests.py index 641e503..b88aaaf 100644 --- a/administration/tests.py +++ b/administration/tests.py @@ -1674,3 +1674,15 @@ class PeriodFormTests(TestCase): form["start_date"].errors, ['masukan waktu mulai'] ) + + def test_validation_error_when_end_date_is_none(self): + data = { + 'start_date': datetime.now(), + 'end_date': None, + } + form = PeriodForm(data) + self.assertFalse(form.is_valid()) + self.assertEqual( + form["end_date"].errors, + ['masukan waktu selesai'] + ) -- GitLab From c95ef47c71d7fae56989b6ed3b0834f8e27e6e64 Mon Sep 17 00:00:00 2001 From: Ahmad Fauzan Amirul Isnain Date: Sat, 31 Oct 2020 12:11:12 +0700 Subject: [PATCH 3/4] [RED] Create tests for PeriodForm validation start date greater than end date --- administration/tests.py | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/administration/tests.py b/administration/tests.py index b88aaaf..0061c8d 100644 --- a/administration/tests.py +++ b/administration/tests.py @@ -1686,3 +1686,16 @@ class PeriodFormTests(TestCase): form["end_date"].errors, ['masukan waktu selesai'] ) + + def test_validation_error_when_start_date_greater_than_end_date(self): + current_time = datetime.now() + data = { + 'start_date': current_time + timedelta(days = 1), + 'end_date': current_time, + } + form = PeriodForm(data) + self.assertFalse(form.is_valid()) + self.assertEqual( + form["end_date"].errors, + ['waktu selesai sebelum waktu mulai'] + ) -- GitLab From 907741ad85a467e378697ae9a48c61e9eac061a8 Mon Sep 17 00:00:00 2001 From: Ahmad Fauzan Amirul Isnain Date: Sat, 31 Oct 2020 12:37:19 +0700 Subject: [PATCH 4/4] [RED] Create tests form valid when data valid --- administration/tests.py | 9 +++++++++ digipus/__pycache__/settings.cpython-36.pyc | Bin 4132 -> 4178 bytes 2 files changed, 9 insertions(+) diff --git a/administration/tests.py b/administration/tests.py index 0061c8d..cc7b72d 100644 --- a/administration/tests.py +++ b/administration/tests.py @@ -1699,3 +1699,12 @@ class PeriodFormTests(TestCase): form["end_date"].errors, ['waktu selesai sebelum waktu mulai'] ) + + def test_form_valid_when_data_valid(self): + current_time = datetime.now() + data = { + 'start_date': current_time - timedelta(days = 1), + 'end_date': current_time, + } + form = PeriodForm(data) + self.assertTrue(form.is_valid()) diff --git a/digipus/__pycache__/settings.cpython-36.pyc b/digipus/__pycache__/settings.cpython-36.pyc index 1cf78ac5dc695e4dca1c09a4b10db034aec54534..43d2d1c4169e7113ebfa287197b9840fd637a652 100644 GIT binary patch delta 670 zcmYk4J#W)c6ozdp&=Qim5-NqQ5TJxKPDok^<*NxXG$d_IoVIZJFc%-=I@qygCqiV& zz|4o_4KX4iM%00U74ZYQAZ0`R3B=T6Hz~1oUO#^Cd+#}t{b_D@E|HJNqs`ABmCA93 z`NND|)5t4W-uthKZ){&@$!RE)1c>AeoFZqj&SA}K6D=NYqn-~n33re$z$$7AD#jtQ zphe&=RH62UBWdI{SPxmy*w$ogMvFoHHAgZak?gpG{Vu{ik{fzT3>p~AgG?5oNtR%P zT!Ky5(piHgm*GAs;L#6&ghyXNeh803UPgWlPeQ(mtiaQdui^05Ax&-oCo@U9^OpO4 zm>u}ek@-}fI*!oo7^Wvk)bn22E^JcM0NSzL14pt=Lw)6ci2h=U?;icp@1>wc+qx~N zwyOyiHB8|dRbOar@C485ID!~>rG0A<71xTDnzCA#o4u)USr50Uwl!Ll>W!vR8!^*5KG!R4U5yR=rUs(?J{z-Eg{|7PLv;+$qGq zbNxYlKVB-{s*3AncLu+=i$4P6&IWP=5UU*+HVfBA)}$%zOX8{QFi4;xg=Z~y=R delta 552 zcmcblutY)Gn3tF9_`HeniJ}Y)j~S4F0Fdnf#KmbFmA5n2r#Pj!WHJItS1{?8$(YU( zrIg|xrJUjsrIMl;r3%DqK&+n1p2eTy2_!YZq-Kg2kgb*C4J5Twd@@<1bW&MTd{g{V z{Ck!|qGE)*uGV}BFLW@(297{@yGLuS6QiC&dGjkG)GD|AMAS&{Us_Z~ob+Bpm&CJWp zEzR{w%}X!IKxnWBY0$-{!8t!SH$N``>I#Go2apbBY&!f(b5n~llVMsWzu~;jcx&~S z-`6q3JJcuG)z@4XYlJ3qHHFLQDVzY62N$({WDY;24mI9WnK2LOy2 BvDp9s -- GitLab