diff --git a/pom.xml b/pom.xml index 0c743de668d5f66edfb08d9a2fea151594122a20..d35db9f34122b7aa268511d3a9f36983dbd927de 100644 --- a/pom.xml +++ b/pom.xml @@ -26,6 +26,9 @@ <jsr305.version>3.0.2</jsr305.version> <jackson-databind-nullable.version>0.2.1</jackson-databind-nullable.version> <mapstruct.version>1.4.1.Final</mapstruct.version> + <jaxb-api.version>2.3.0</jaxb-api.version> + <openapi-generator-maven-plugin.version>5.2.1</openapi-generator-maven-plugin.version> + <build-helper-maven-plugin.version>3.2.0</build-helper-maven-plugin.version> </properties> <dependencies> @@ -156,7 +159,7 @@ <dependency> <groupId>javax.xml.bind</groupId> <artifactId>jaxb-api</artifactId> - <version>2.3.0</version> + <version>${jaxb-api.version}</version> </dependency> </dependencies> @@ -252,7 +255,7 @@ <groupId>org.openapitools</groupId> <artifactId>openapi-generator-maven-plugin</artifactId> <!-- RELEASE_VERSION --> - <version>5.2.1</version> + <version>${openapi-generator-maven-plugin.version}</version> <!-- /RELEASE_VERSION --> <executions> <execution> @@ -290,7 +293,7 @@ <plugin> <groupId>org.codehaus.mojo</groupId> <artifactId>build-helper-maven-plugin</artifactId> - <version>3.2.0</version> + <version>${build-helper-maven-plugin.version}</version> <executions> <execution> <id>add-source</id> diff --git a/src/main/java/org/springframework/samples/petclinic/rest/VisitRestController.java b/src/main/java/org/springframework/samples/petclinic/rest/VisitRestController.java index c320a3287201fb4a9867565fdde3de21159ff622..ee92cf38fa98366ce519813067f4f636c6c68f2a 100644 --- a/src/main/java/org/springframework/samples/petclinic/rest/VisitRestController.java +++ b/src/main/java/org/springframework/samples/petclinic/rest/VisitRestController.java @@ -82,7 +82,7 @@ public class VisitRestController { if (bindingResult.hasErrors() || (visitDto == null)) { errors.addAllErrors(bindingResult); headers.add("errors", errors.toJSON()); - return new ResponseEntity<>(headers, HttpStatus.BAD_REQUEST); + return new ResponseEntity<VisitDto>(headers, HttpStatus.BAD_REQUEST); } Visit visit = visitMapper.toVisit(visitDto); this.clinicService.saveVisit(visit); diff --git a/src/test/java/org/springframework/samples/petclinic/rest/VetRestControllerTests.java b/src/test/java/org/springframework/samples/petclinic/rest/VetRestControllerTests.java index 78edfdc0d53b267becd2152719bb32e21399ccc8..7b90a41f60a04e21eedd2f0e0dcd019ff264f850 100644 --- a/src/test/java/org/springframework/samples/petclinic/rest/VetRestControllerTests.java +++ b/src/test/java/org/springframework/samples/petclinic/rest/VetRestControllerTests.java @@ -189,7 +189,7 @@ public class VetRestControllerTests { @WithMockUser(roles="VET_ADMIN") public void testUpdateVetError() throws Exception { Vet newVet = vets.get(0); - newVet.setFirstName(""); + newVet.setFirstName(null); ObjectMapper mapper = new ObjectMapper(); String newVetAsJSON = mapper.writeValueAsString(vetMapper.toVetDto(newVet)); this.mockMvc.perform(put("/api/vets/1") diff --git a/src/test/java/org/springframework/samples/petclinic/rest/VisitRestControllerTests.java b/src/test/java/org/springframework/samples/petclinic/rest/VisitRestControllerTests.java index 1a760852db1d2b5d7438acc0fa8f88b0b59e5b97..cd51385e9980ec2ea5d1a72a3fa750d92fb88d85 100644 --- a/src/test/java/org/springframework/samples/petclinic/rest/VisitRestControllerTests.java +++ b/src/test/java/org/springframework/samples/petclinic/rest/VisitRestControllerTests.java @@ -174,7 +174,6 @@ public class VisitRestControllerTests { .andExpect(status().isCreated()); } - @Test(expected = IOException.class) @WithMockUser(roles="OWNER_ADMIN") public void testCreateVisitError() throws Exception { Visit newVisit = visits.get(0); @@ -208,7 +207,6 @@ public class VisitRestControllerTests { .andExpect(jsonPath("$.description").value("rabies shot test")); } - @Test(expected = IOException.class) @WithMockUser(roles="OWNER_ADMIN") public void testUpdateVisitError() throws Exception { Visit newVisit = visits.get(0);