Merge branch 'bugfix/PBI-8-username-password-fixes' into 'staging'

PBI-8: Bugfix - Implement password validator and standardize all username to lowercase

See merge request !31

apps/accounts/serializers.py

+from django.contrib.auth import password_validation
 from rest_framework import serializers
+
 from apps.accounts.models import Account
 
 
@@ -41,3 +43,7 @@ class AccountRegisterSerializer(serializers.ModelSerializer):
             "area",
             "is_admin",
         ]
+
+    def validate_password(self, value):
+        password_validation.validate_password(value)
+        return value

apps/accounts/tests/test_units/test_accounts.py

@@ -150,19 +150,37 @@ class AccountViewTest(APITestCase):
             '"action_type":"{}"'.format(ACTIVITY_TYPE_CREATE), response_string
         )
 
-    def test_create_new_account_fails_with_no_auth_info(self):
+    def test_username_lowercased(self):
         url = self.BASE_URL
 
+        data = {
+            "name": self.faker.name(),
+            "username": "aBcDeFgH",
+            "password": "justpass",
+            "email": self.faker.email(),
+            "phone_number": self.faker.phone_number(),
+            "area": self.faker.city(),
+            "is_admin": False,
+        }
+
+        self.client.post(
+            path=url, data=data, format="json",
+        )
+        self.assertTrue(Account.objects.filter(user__username="abcdefgh").exists())
+
+    def test_create_new_account_fails_with_poor_password(self):
+        url = self.BASE_URL
         _account_id = self.faker.email()
 
         data = {
             "name": self.faker.name(),
             "email": _account_id,
+            "username": _account_id,
+            "password": "12345678",
             "phone_number": self.faker.phone_number(),
             "area": self.faker.city(),
             "is_admin": False,
         }
-
         response = self.client.post(path=url, data=data, format="json",)
         self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
 

apps/accounts/views.py

@@ -51,7 +51,7 @@ class AccountViewSet(viewsets.ViewSet):
         serializer = AccountRegisterSerializer(data=request.data)
         serializer.is_valid(raise_exception=True)
 
-        username = serializer.validated_data.pop("username")
+        username = serializer.validated_data.pop("username").lower()
         password = serializer.validated_data.pop("password")
 
         user = User.objects.create_user(username=username, password=password)