From 125e7f7f6c621de4554216848fd3f3b4984ef02c Mon Sep 17 00:00:00 2001
From: riorio805 <sefrianojieftara@gmail.com>
Date: Fri, 28 Feb 2025 16:39:09 +0700
Subject: [PATCH] [REFACTOR] Remove duplicated string in seeding with existing
string constant
---
.../authentication/seeder/DevDataSeeder.java | 13 ++++++++-----
.../service/AuthenticationService.java | 2 +-
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/src/main/java/com/safetypin/authentication/seeder/DevDataSeeder.java b/src/main/java/com/safetypin/authentication/seeder/DevDataSeeder.java
index 58dc982..4f23a81 100644
--- a/src/main/java/com/safetypin/authentication/seeder/DevDataSeeder.java
+++ b/src/main/java/com/safetypin/authentication/seeder/DevDataSeeder.java
@@ -2,6 +2,9 @@ package com.safetypin.authentication.seeder;
import com.safetypin.authentication.model.User;
import com.safetypin.authentication.repository.UserRepository;
+import static com.safetypin.authentication.service.AuthenticationService.EMAIL_PROVIDER;
+
+import com.safetypin.authentication.service.AuthenticationService;
import jakarta.annotation.PostConstruct;
import org.springframework.context.annotation.Profile;
import org.springframework.security.crypto.password.PasswordEncoder;
@@ -36,7 +39,7 @@ public class DevDataSeeder implements Runnable {
true,
"user",
LocalDate.of(1990, 1, 1),
- "EMAIL",
+ EMAIL_PROVIDER,
"social1"));
userRepository.save(new User("user2@example.com",
@@ -45,7 +48,7 @@ public class DevDataSeeder implements Runnable {
true,
"user",
LocalDate.of(1991, 2, 2),
- "EMAIL",
+ EMAIL_PROVIDER,
"social2"));
userRepository.save(new User("user3@example.com",
@@ -54,7 +57,7 @@ public class DevDataSeeder implements Runnable {
true,
"user",
LocalDate.of(1992, 3, 3),
- "EMAIL",
+ EMAIL_PROVIDER,
"social3"));
userRepository.save(new User("user4@example.com",
@@ -63,7 +66,7 @@ public class DevDataSeeder implements Runnable {
true,
"user",
LocalDate.of(1993, 4, 4),
- "EMAIL",
+ EMAIL_PROVIDER,
"social4"));
userRepository.save(new User("user5@example.com",
@@ -72,7 +75,7 @@ public class DevDataSeeder implements Runnable {
true,
"user",
LocalDate.of(1994, 5, 5),
- "EMAIL",
+ EMAIL_PROVIDER,
"social5"));
}
}
diff --git a/src/main/java/com/safetypin/authentication/service/AuthenticationService.java b/src/main/java/com/safetypin/authentication/service/AuthenticationService.java
index 96bca07..3a177cc 100644
--- a/src/main/java/com/safetypin/authentication/service/AuthenticationService.java
+++ b/src/main/java/com/safetypin/authentication/service/AuthenticationService.java
@@ -15,7 +15,7 @@ import java.time.Period;
@Service
public class AuthenticationService {
- private static final String EMAIL_PROVIDER = "EMAIL";
+ public static final String EMAIL_PROVIDER = "EMAIL";
private final UserRepository userRepository;
private final PasswordEncoder passwordEncoder;
--
GitLab