From ee29c7252af1bc866a659df250ed632c9526ac49 Mon Sep 17 00:00:00 2001
From: KronosDP <darrel.danadyaksa19@gmail.com>
Date: Tue, 11 Mar 2025 15:14:07 +0700
Subject: [PATCH] fix: update SonarQube workflow and remove unused check
execution from pom.xml
---
.github/workflows/sonarqube.yml | 10 +++++-----
pom.xml | 20 --------------------
2 files changed, 5 insertions(+), 25 deletions(-)
diff --git a/.github/workflows/sonarqube.yml b/.github/workflows/sonarqube.yml
index e30a48e..30482b0 100644
--- a/.github/workflows/sonarqube.yml
+++ b/.github/workflows/sonarqube.yml
@@ -2,9 +2,9 @@ name: SonarQube
on:
push:
branches:
- - '*'
+ - "*"
pull_request:
- types: [ opened, synchronize, reopened ]
+ types: [opened, synchronize, reopened]
jobs:
build:
@@ -14,12 +14,12 @@ jobs:
steps:
- uses: actions/checkout@v4
with:
- fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
+ fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
- name: Set up JDK 21
uses: actions/setup-java@v4
with:
java-version: 21
- distribution: 'zulu' # Alternative distribution options are available.
+ distribution: "zulu" # Alternative distribution options are available.
- name: Cache SonarQube packages
uses: actions/cache@v4
with:
@@ -36,4 +36,4 @@ jobs:
env:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }}
- run: mvn -B org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Dsonar.projectKey=safetypin-be-auth -Dsonar.projectName='safetypin-be-auth'
\ No newline at end of file
+ run: mvn -B verify org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Dsonar.projectKey=safetypin-be-auth -Dsonar.projectName='safetypin-be-auth'
diff --git a/pom.xml b/pom.xml
index a63ccbe..c842d68 100644
--- a/pom.xml
+++ b/pom.xml
@@ -304,26 +304,6 @@
<goal>report</goal>
</goals>
</execution>
- <execution>
- <id>check</id>
- <goals>
- <goal>check</goal>
- </goals>
- <configuration>
- <rules>
- <rule>
- <element>BUNDLE</element>
- <limits>
- <limit>
- <counter>LINE</counter>
- <value>COVEREDRATIO</value>
- <minimum>1.00</minimum>
- </limit>
- </limits>
- </rule>
- </rules>
- </configuration>
- </execution>
</executions>
</plugin>
</plugins>
--
GitLab