Fakultas Ilmu Komputer UI

Skip to content
Snippets Groups Projects

Replace Magic Number with Symbolic Constant on Model Class Application

Merged Muh Riansyah Tohamba requested to merge 1806280520-245 into master
2 files
+ 3
3
Compare changes
  • Side-by-side
  • Inline
Files
2
@@ -30,13 +30,13 @@ class StudentSerializer(serializers.ModelSerializer):
@staticmethod
def get_accepted_no(obj):
apps = Application.objects.filter(student=obj, status=4)
apps = Application.objects.filter(student=obj, status=Application.ACCEPTED)
companies = apps.values('vacancy__company').distinct()
return companies.count()
@staticmethod
def get_read_no(obj):
apps = Application.objects.filter(student=obj, status=1)
apps = Application.objects.filter(student=obj, status=Application.READ)
companies = apps.values('vacancy__company').distinct()
return companies.count()
Loading